Repository navigation
Trim the proposal sidebar's RFP and prize cards - #1318
Merged
Merged
Conversation
The linked RFP card now shows only the RFP's title and its organization. The amount, the open or closed status and the proposal count are gone: the prize card above already shows the money, and Kobe asked for less text across the site. The prize card's Awarded step drops its funder lines, "<funder> picks who wins the prize once results are posted." while open and "From <funder>" once awarded, since the RFP card names the funder. "The prize has closed" stays.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
LinkedRfpCard.tsx): shows only the RFP title and its organization. The amount, Open/Closed status and proposal/competitor count are removed. The organization line is skipped when it's the same as the title.AwardProposalCard.tsx): the Awarded step no longer has funder subtext. " picks who wins the prize once results are posted." (while open) and "From " (once awarded) are both gone, since the RFP card below names the funder. "The prize has closed", the "N updates" link and the author's "Share your progress and results." stay.Why
The sidebar had too much text. The prize card already shows the money, so the RFP card's amount was a duplicate.